PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. If contributing template-only or documentation-only changes which will change sample output, be sure to build the project first. -
Filed the PR against the correct branch: master
,. Default:3.4.x
,4.0.x
master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
Travis CI will timeout if there is no activity printed to stdout or stderr for 10 minutes. Running our mvn commands with --quiet option may hit this limit for any number of reasons (more code, network conditions). To avoid this, we remove --quiet and adjust some other Maven configuration options.
One, specifically, is the cached .m2/repository directory. We bind this to a non-user home location due to the -u binding found in run-in-docker.sh. We then provide a settings.xml and CLI option to tell maven where to look for our cached repository directory. This should allow both users and CI to run the script in a consistent way, but most importantly should allow Travis to continue to cache artifacts across builds.