Created by: karismann
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
,./bin/openapi3/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. -
Filed the PR against the correct branch: master
,. Default:3.4.x
,4.0.x
master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @jimschubert (2017/09), @dr4ke616 (2018/08) @Zomzog (2019/04)
Description of the PR
a var with all upper case and numbers (e.g USER123NAME
) is incorrectly converted to (e.g usER123NAME
) and the getter/setter generated is wrong (e.g getUsER123NAME()
)
with the fix (following the all upper case var rule) :
USER123NAME
stay USER123NAME
and the getter is getUSER123NAME()
thanks to @JorgeMorata to detect this issue