fix allof in javascript generator (!2753) · Merge requests · OpenAPI Tools / openapi-generator

Closed Administrator requested to merge github/fork/Sakerdot/master into master Apr 27, 2019

Created by: Sakerdot

PR checklist

Read the contribution guidelines.
Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
Filed the PR against the correct branch: master~~, 3.4.x, 4.0.x~~. Default: master.
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Required parameters from inherited schemas were not being included on the constructor of the resulting schema when using allOf. These were included on the body of the constructor by using the {{#interfaceModels}} tag.

Fix for https://github.com/OpenAPITools/openapi-generator/issues/2438 @CodeNinjai (2017/07) @frol (2017/07) @cliffano (2017/07)