Skip to content
GitLab

[Csharp] add nullable support to API client

Merged Administrator requested to merge github/fork/drl-max/csharp-nullable-support into master

Created by: drl-max

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Followed a similar pattern to how the new csharp-netcore generator handles nullable support. I added an additional testcase as well. It verifies that a property marked as not-nullable will not generate the nullable form of it's type. Also, I verify that types that don't support the nullable type shorthand aren't affected, ie. a string. Please let me know if this is sufficient or if there are other cases you'd like me to capture.

I did not provide any files for the CI because it appears only the csharp-dotnet2 client has files committed to the project. Please let me know if you'd like me to run the csharp-petstore-all script and commit everything that's generated.

I think this can resolve the client-side request for issue #2269 (@wing328, hopefully this helps! I also have a PR prepped for the server-side as well).

@jimschubert @mandrean - Please review and let me know if you have any feedback,