Skip to content
GitLab

[PHP-Symfony] Catch serializer exception

Merged Administrator requested to merge github/fork/ossinkine/catch-serializer-exception into master

Created by: ossinkine

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Since we use StrictJsonDeserializationVisitor which can throw an exception on type mismatch we should catch this exception and consider it as validation error and return "Bad request" response.

cc @jebentier @dkarlovi @mandrean @jfastnacht @ackintosh @ybelenko @renepardon