Skip to content
GitLab

[WIP] Fix allOf in inline model resolver

Closed William Cheng requested to merge improve_flatten into master

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.4.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Found this bug while working on better allOf, anyOf, oneOf support: model instanceof Schema should be the last check, otherwise all other checks (eg.. ArraySchema) will be skipped.

Also deprecating fixStringModel as we shouldn't need it to remove double quote in enum example value

cc @OpenAPITools/generator-core-team