Created by: spacether
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. -
Filed the PR against the correct branch: master
,. Default:3.4.x
,4.0.x
master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @wing328 @jimschubert @cbornet @jaz-ah @ackintosh @JFCote @jmini
Description of the PR
- This PR adds the model XmlItem and a route that uses it to the swagger 2.0 sample spec. It also includes 6 xml mime types that are produced + consumed in that route. Downstream clients can use this model and that route for their xml tests.
- It adds an Api suffix on the java rest-assured client to pass CircleCi tests
- It pegs the versions of pytest and pytest-cov to fix and pass TravisCI tests
- It fixes the python models get_real_child_model method so deserialization tests pass
- Removes unused models and tests from the sample python clients
The examples currently in the spec do not include all xml attributes. The XmlItem model includes all xml attributes:
- name
- attribute
- wrapped
- prefix
Issue Closure
When merged this PR will close these issues:
- [BUG] swagger 2.0 spec is missing an xml example with all xml fields https://github.com/OpenAPITools/openapi-generator/issues/1807
- [java rest-assured] default is a reserved keyword https://github.com/OpenAPITools/openapi-generator/issues/13
- [CI] Python Tests Failing in TravisCI https://github.com/OpenAPITools/openapi-generator/issues/1832