Skip to content
GitLab

Remove @JsonTypeName from okhttp-gson POJOs

Open bernie-schelberg-mywave requested to merge github/fork/bernie-schelberg-mywave/remove-json-type-name-okhttp-gson into master

sibling PR to https://github.com/OpenAPITools/openapi-generator/pull/14842, https://github.com/OpenAPITools/openapi-generator/pull/14852, https://github.com/OpenAPITools/openapi-generator/pull/14854 and #14855 . This PR removes the @JsonTypeName annotation from the okhttp-gson templates. I want to make some other changes that affect the handling of the @JsonTypeName annotation, and investigating those issues led to the conclusion that @JsonTypeName is unnecessary, as the name of the type is specified in the super class' @JsonSubTypes annotation wherever necessary.

Submitting this as a separate PR in the interests of keeping PRs small and focussed. This change didn't affect any existing samples.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • In case you are adding a new generator, run the following additional script : 
    ./bin/utils/ensure-up-to-date.sh
    Commit all changed files.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)