Merged
requested to merge github/fork/Rattenkrieg/ktor-client-add-toString()-for-generic-params into master
Created by: Rattenkrieg
ktor-client doesn't support building form request from arbitrary parameters: it will happily consume values of predefined types such as String
, Number
etc but will fail in runtime (!) at a given line in case of say List<T>
or Instant
.
https://github.com/ktorio/ktor/blob/fb161cd7d268f2c0f62982d82d9264ca920173ad/ktor-client/ktor-client-core/common/src/io/ktor/client/request/forms/formDsl.kt#L63
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
In case you are adding a new generator, run the following additional script : ./bin/utils/ensure-up-to-date.sh
-
File the PR against the correct branch: master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @wing328