Open
requested to merge github/fork/salimzdn/fix_csharp-netcore_snake_case_constructors_generation into master
Created by: salimzdn
resolve #14571
This PR resolves the issue by removing camelCase transformation in models constructor for csharp-netcore.
Using this OpenApi specificatin file
{
"openapi": "3.0.1",
"info": {
"title": "My Web API",
"description": "My Web API",
"version": "1.22.2"
},
"tags": [],
"paths": {},
"components": {
"schemas": {
"MyTokenType": {
"type": "string",
"description": "Token type",
"enum": [
"JWT",
"OIDC_ACCESS_TOKEN"
],
"x-enum-descriptions": [
"JWT",
"OIDC_ACCESS_TOKEN"
]
},
"MyTokenRequest": {
"type": "object",
"description": "My token request",
"properties": {
"$_type": {
"type": "string",
"default": "MyTokenRequest",
"enum": [
"MyTokenRequest"
]
},
"token": {
"type": "string"
},
"type": {
"$ref": "#/components/schemas/MyTokenType"
}
}
}
}
}
}
And using this config file
{
"packageName" : "com.myApi",
"nullableReferenceTypes" : true,
"targetFramework" : "net6.0",
"modelPropertyNaming" : "snake_case"
}
And using this command
npx openapi-generator-cli generate -i swagger_simple_anonymised.json -g csharp-netcore -o out_dotnet -c openApiGeneratorConfig.json
Without the fix, the resulted constructor was
public MyTokenRequest(TypeEnum? type = TypeEnum.MyTokenRequest, string token = default(string), MyTokenType? type = default(MyTokenType?))
{
this._type = type;
this.token = token;
this.type = type;
}
With the fix, the resulted constructor is now
public MyTokenRequest(TypeEnum? _type = TypeEnum.MyTokenRequest, string token = default(string), MyTokenType? type = default(MyTokenType?))
{
this._type = _type;
this.token = token;
this.type = type;
}
See issue #14571 to know more
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
(Not needed here) In case you are adding a new generator, run the following additional script : ./bin/utils/ensure-up-to-date.sh
-
File the PR against the correct branch: master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@mandrean @shibayan @Blackclaws @lucamazzanti