Closed
requested to merge github/fork/bjorgvino/fix-supportUrlQuery-templates-and-additionalProperties into master
Created by: bjorgvino
Generated models for arrays marked with uniqueItems: true
(which end up as a Set<>
in java) won't compile because the templates are in some places using .get(i)
on the sets.
Also, when the supportUrlQuery
property is present in the additionalProperties
map the resulting value will be read using the constant SUPPORT_STREAMING
instead of the key 'supportUrlQuery'.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. - [-] Run the following to build the project and update samples:
./mvnw clean package <--- Get errors when I run this on a clean `master`... ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10)