Created by: joeboyscout04
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. -
Filed the PR against the correct branch: master
,3.4.x
,4.0.x
. Default:master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @jgavris @ehyche @Edubits @jaz-ah @d-date
Description of the PR
This PR updates various parts of the swift4 package including:
- Update Alamofire dependency so it is compatible with Swift 4.2
- Update run_xcodebuild.sh in the tests to use iPhone 8,OS=12.1 so the tests are runnable on modern versions of Xcode.
- Fixes a few compilation issues with running the tests on XCode 10
- Updates the naming of the artifactId in the pom.xml for the tests to say "Swift4" instead of Swift3.