Skip to content
GitLab

[GO][Client] Use a `*os.File` for the API Client when uploading and downloading

Merged Administrator requested to merge github/fork/icubbon/goFilePointerChange into master

Created by: icubbon

Downloading and uploading files for the Go Client were broken recently but then fixed with https://github.com/OpenAPITools/openapi-generator/pull/14046. However this fix breaks the pattern of the API returning pointers to things.

This change makes the API return *os.File and accept *os.File for uploading and downloading.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328