Created by: dschu-lab
Introducing the following changes
- Sets the
name
property inside class constructor - Updated samples
Motivation
The setting noImplicitOverride
leads to a more robust codebase. However, setting this option resulted in an error since the class was overriding the name
property without marking it as override.
References
- TS Documentation noImplicitOverride
- https://github.com/OpenAPITools/openapi-generator/pull/14225 (First attempt to solve this issue)
Pinging the commitee for visibility
@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.