Created by: joelongstreet
This pull request updates the typescript-nest client generator to use URLSearchParams
instead of an empty object when storing and referencing query parameters. This fixes a bug where the generator would build invalid typescript.
Using the examples described in this issue, the following typescript would be generated:
let queryParameters = {};
if (brandOrganizationId) {
brandOrganizationId.forEach((element) => {
queryParameters.append('brandOrganizationId', <any>element);
})
}
The queryParameters
object is a plain object and doesn't have the append
method available. This change updates queryParameters
to always be an instance of URLSearchParams
where append
is an available method.
Axios (the http client in this case), accepts an instance of URLSearchParams
or a string as the params property. This pull request updates all query params to be passed as URLSearchParams
.
Closes https://github.com/OpenAPITools/openapi-generator/pull/13638 Closes https://github.com/OpenAPITools/openapi-generator/issues/14134
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(6.3.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.