Created by: thomasphansen
Fixes #13635 (closed), by correcting a regression added by #11225 and extending #12120 adjustments.
ObjectSerializer::toQueryValue() filters out parameters whose values are "empty" (using the empty()
method from php), but it disregards the value's type when doing so. A single exception is added for the false value, if the OpenApi type is boolean.
This PR add checks for numeric fields, since the value "0" (both integer and float) should not be filtered out. New tests are added, covering 100% of the added lines.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the [technical committee] @jebentier, @dkarlovi, @mandrean, @jfastnacht, @ybelenko, @renepardon