Skip to content
GitLab

Add supporting test handling like models and API

Open Administrator requested to merge github/fork/Zomzog/zomzog/13677_generate_supporting_tests into master

Created by: Zomzog

This PR should fix #13677 The idea is to allow the handling of supporting files test like it is done for models and API.

With the PR we can do this for spring and have the tests well generated in the right folder:

<configuration>
    <inputSpec>${project.basedir}/src/main/resources/openapi.yaml</inputSpec>
    <generatorName>spring</generatorName>
    <library>spring-boot</library>
    <generateSupportingFilesTests>true</generateSupportingFilesTests>
    <configOptions>
        <testOutput>${project.basedir}/target/generated-test-sources</testOutput>
    </configOptions>
</configuration>

The only impact seen so far is with spring-camel but I don't get why the test was not generated before.

No impact is expected on other generators than java-spring because I've migrated nothing else for now. But I think if the PR is merged the same fix can be done for other generators (like kotlin-spring)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

ping : @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02)