Created by: danielbrammertz
The generated *.service.ts files did not compile when query-parameters with isCollectionFormatMulti=true It produced errors in the following way:
ERROR in ./generated_sources/finapi/access-service/api/transactions.service.ts 478:33-39
TS2339: Property 'append' does not exist on type '{}'.
476 | if (order) {
477 | order.forEach((element) => {
> 478 | queryParameters.append('order', <any>element);
| ^^^^^^
479 | })
480 | }
481 |
This was fixed, by making queryParameters an instance of URLSearchParam instead of a plain object. Furthermore it turned out, that for regular (non-multi) parameters it is also necessary to append them to URLSearchParam, since the parameters were not sent otherwise
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.