Skip to content
GitLab

[typescript-axios] / #12828: Add ESM support to typescript-axios client

Merged Administrator requested to merge github/fork/miniengineer/fix_issue12828 into master

Created by: miniengineer

fix https://github.com/OpenAPITools/openapi-generator/issues/12828

An additional tsconfig.esm.json is added to every generated typescript-axios code having supportsES6 and npmName. That will create an additional ECMAScript Module (ESM) to the npm build.

I used similar PR for typescript-fetch client as reference https://github.com/OpenAPITools/openapi-generator/pull/11720

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @topce @akehir @petejohansonxo @amakhrov @davidgamero @mkusaka