Created by: amakhrov
Fixes https://github.com/OpenAPITools/openapi-generator/issues/13380
This has somewhat long history:
- Earlier bug reports back in 2020: https://github.com/OpenAPITools/openapi-generator/issues/7557
- An attempt to fix the
isBodyAllowed
populated by the Java code: https://github.com/OpenAPITools/openapi-generator/pull/10751 . - That PR resulted in broken generated TypeScript code (https://github.com/OpenAPITools/openapi-generator/issues/10975, https://github.com/OpenAPITools/openapi-generator/issues/10864) and was later reverted. This was unfortunate, because in its core, that PR did the right thing
The approach implemented in this PR only affects typescript-angular generator. Generated code uses HttpClient#request
directly instead of using its http-method-specific wrappers. Also the condition for isBodyAllowed
was removed. It means body inclusion in the request only depends on the presence of body schema in the spec and doesn't depends on the http method. This generally matches a similar change in swagger-codegen: https://github.com/swagger-api/swagger-codegen-generators/pull/568.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)