Created by: kalinjul
This PR fixes #12531 (closed) and implements enums for kotlin-retrofit mostly by using the template from okhttp.
I added a enumDefaultValue
field in CodeGenParameter that holds the default enum for enum types.
This was necessary because defaultValue
holds the value of the enum, not the enum name. This is not the the same in some cases (for example, "de-DE" is converted to enum "deMinusDe").
defaultValue still holds the (String) value, so templates that do not support enums are not affected by this change.
I kept the per-method enum generation with Enum types named {{enumName}}_{{operationId}}
that okhttp template used, although i think it's a bit clumsy.
This was tested in my project with kotlin jvm-retrofit2 and with okhttp and the json from the bug mentioned above.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@jimschubert: mentioning you for review