Merged
requested to merge github/fork/Kevin-Bannier/fix/python-flask-incorrect-boolean-literal-unit-tests into master
Created by: Kevin-Bannier
Fixes #9386 (closed)
When using generators python-flask
and python-aiohttp
, the generated test body boolean values reads now as follows ("True" or "False"):
body = {
"boolean_property": True
}
Previous buggy generated code:
body = {
"boolean_property": true
}
Most of the code is copy-paste from generator python-fastapi
(PythonFastAPIServerCodegen.java)
Steps to see the new generated code:
java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate \
-i modules/openapi-generator/src/test/resources/3_0/petstore.yaml \
-g python-flask \
-o /var/tmp/python-flask
cat /var/tmp/python-flask/openapi_server/test/test_store_controller.py
java -jar modules/openapi-generator-cli/target/openapi-generator-cli.jar generate \
-i modules/openapi-generator/src/test/resources/3_0/petstore.yaml \
-g python-aiohttp \
-o /var/tmp/python-aiohttp
cat /var/tmp/python-aiohttp/tests/test_store_controller.py
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @arun-nalla @spacether