[Java][Feign] convert expirationTimeSeconds to milliseconds (!13361) · Merge requests · OpenAPI Tools / openapi-generator

Merged Administrator requested to merge github/fork/kmaginot/issue13339_feign_oauth_token_caching into master Sep 06, 2022

Created by: kmaginot

Hi @wing328 @bbdouglas @sreeshas, @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608, this is my proposed fix for https://github.com/OpenAPITools/openapi-generator/issues/13339

The Java OAuth RequestInterceptor implementation for Feign currently verifies if a previously obtained access token needs to be renewed by checking if System.currentTimeMillis() is greater than expirationTimeSeconds. This causes a new access token to be requested for each interaction. Converting expirationTimeSeconds to milliseconds should fix this.

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.