Created by: mrginglymus
The changes in #12348 meant that $ref
s in allOf
schemas generated new model names. However, a common pattern is to have a referenced schema with the only modification being readOnly
, which is a change to the parent not the referenced schema. In order to not generate duplicate models, special case this one special case.
A demonstration of the problematic model has been included as a typescript-fetch client.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.