Created by: joaomlneto
Generated code does not compile with recent apollo-server
versions. This PR attempts to make it generate compatible code with latest versions of the Apollo libraries.
Comments/reviews are highly desired! I do not fully understand the code, but my changes appear to fix compilation issues.
I'm submitting it to the master
branch, but may be more appropriate to submit it to another branch?
Additionally, this may break compatibility with potential users using very old versions. What would be the best course of action to tackle this?
NodeJS/Javascript technical committee: @CodeNinjai @frol @cliffano
Closes #13190 (closed)
Todo list:
-
Bump Apollo Server compatibility to version 3 -
Fix tests -
Fix parameters pased onto callApi — parameters contentTypes
andaccepts
are missing. -
https://github.com/apollographql/apollo-server/pull/1277 — make requestInit
parameter available in every endpoint, passed ontocallApi
, subsequently passed onto theget
/post
/delete
/patch
/put
methods onRESTDataSource
.
Resources
- Previous code included
apollo-datasource-rest
library version 0.7.0. Browseapollo-datasource-rest@v0.7.0
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.