Merged
requested to merge github/fork/ykitamura-mdsol/ruby-remove-verbose-option-from-faraday into master
Created by: ykitamura-mdsol
We've run into this issue when setting config.debugging = true
:
require 'petstore'
api_instance = Petstore::FakeApi.new
Petstore.configure do |config|
config.debugging = true
end
result = api_instance.fake_health_get
D, [2022-07-28T13:52:50.321834 #25054] DEBUG -- : Calling API: FakeApi.fake_health_get ... openapi-generator/samples/client/petstore/ruby-faraday/lib/petstore/api_client.rb:115:in
build_request': undefined method
verbose=' for #<Faraday::RequestOptions timeout=60> (NoMethodError)request.options.verbose = config.debugging if config.debugging ^^^^^^^^^^^^^^^^^
Looks like the verbose
option comes from typhoeus but there is no support in Faraday:
https://github.com/lostisland/faraday/blob/v1.8.0/lib/faraday/options/request_options.rb#L5-L8
It had not been an issue but in this PR, the way to configure options was changed so the problem has surfaced:
- request.options = OpenStruct.new(req_opts)
:
+ request.options.verbose = @config.debugging if @config.debugging
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.