Created by: joeheyming
If there is a communication error, e.g. an OPTIONS request returns 404 not found, then the whole request is cancelled and there is no response object (it is undefined).
I observed the following error: TypeError: Cannot read properties of undefined (reading 'status') Basically response was undefined.
In order to circumvent this issue, we do a check to make sure response is "truthy", which works for objects.
With these code changes, it will throw a ResponseError, which is what you would expect instead of a TypeError.
PR checklist
- [x ] Read the contribution guidelines.
- [x ] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
-
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.