Created by: edwardmp
Commit 1735ab9d added changes to set the jakarta_annotation_version
.
I've recently noticed that when using retrofit2 library, the project builds fine with Maven but fails with Gradle.
The build fails due to Could not get unknown property 'jakarta_annotation_version' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler
.
Digging into this, in the generated build.gradle
the jakarta_annotation_version
is never set.
Upon closer inspection, aforementioned commit seems to indeed set it differently for the Maven build configuration than the Gradle build configuration (same for SBT configuration) for that matter.
The issue is that due to human error the jakarta_annotation_version
line is added within the {{#usePlayWS}}
block, meaning it won't be generated when usePlayWS
is false, even though it should.
This commit changes this to always generate it.
E.g. before applying this commit build.gradle
looks like:
ext {
oltu_version = "1.0.1"
retrofit_version = "2.3.0"
swagger_annotations_version = "1.5.22"
junit_version = "4.13.2"
json_fire_version = "1.8.0"
}
After applying the change:
ext {
oltu_version = "1.0.1"
retrofit_version = "2.3.0"
jakarta_annotation_version = "1.3.5"
swagger_annotations_version = "1.5.22"
junit_version = "4.13.2"
json_fire_version = "1.8.0"
}
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(6.1.0) (minor release - breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.