Closed
requested to merge github/fork/arvindkrishnakumar-okta/fix_inheritance_issue_anyof_without_discriminator into master
Created by: arvindkrishnakumar-okta
Fixes https://github.com/OpenAPITools/openapi-generator/issues/9756
This PR contains changes to add missing Inheritance hierarchy when anyOf
is used without discriminator
in Open API Spec.
Given the below spec for e.g.:
openapi: 3.0.2
info:
title: OAI Specification example for Polymorphism
version: 1.0.0
paths:
/pet:
get:
responses:
'200':
description: desc
content:
application/json:
schema:
$ref: '#/components/schemas/Pet'
/cat:
get:
responses:
'200':
description: desc
content:
application/json:
schema:
$ref: '#/components/schemas/Cat'
components:
schemas:
Pet:
type: object
properties:
prop-x:
type: boolean
Cat:
allOf:
- $ref: '#/components/schemas/Pet'
- type: object
properties:
prop-y:
type: boolean
Expected:
DefaultCodegen codegen = new DefaultCodegen();
codegen.setLegacyDiscriminatorBehavior(false);
codegen.setOpenAPI(openAPI);
Schema catSchema = openAPI.getComponents().getSchemas().get("Cat");
CodegenModel catModel = codegen.fromModel("Cat", catSchema);
assertEquals(catModel.getParent(), "Pet");
Actual:
catModel.getParent() is NULL
This PR intends to fix the above issue.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(6.0.1) (patch release),6.1.x
(breaking changes with fallbacks),7.0.x
(breaking changes without fallbacks) -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
cc: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @wing328