Created by: cachescrubber
Re-generate all model tests
Model tests files are skipped from code generation unconditionally once they exist. This commit re-generates all model test files to see what issues may arise.
The generator option skipOverwrite / -s / --skip-overwrite
option also guards the model test files.
Issues for Developers
-
Generated model test files are never re-generated - no QA for test files.
-
QA builds break when test classes contain stale code.
-
The Only option is to delete the sample project before the generator runs.
-
The generate-samples.sh script needs to run twice, because the second run generates s different FILES list.
Possible Solutions
- Just remove the override protection, use the existing skipOverwrite option.
- Introduce a new Option, skipTestOverwrite.
- In generate-samples.sh, delete the sample output directory before each run.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.