Skip to content
GitLab

[python-experimental] BoolSchema + NoneSchema improvements

Merged Administrator requested to merge feat_moves_none_true_false_to_bases into master

Created by: spacether

  • Fixes https://github.com/OpenAPITools/openapi-generator/issues/12388
  • is_none moved from NoneClass into NoneBase so now it is visible as a method in pycharm, + docstring added
  • is_true moved from BoolClass into BoolBase so now it is visible as a method in pycharm, + docstring added
  • is_false moved from BoolClass into BoolBase so now it is visible as a method in pycharm, + docstring added
  • Values for is_false fixed
  • tests updated to test is_none, is_true, and is_false

If I don't hear back from @meawoppl in a day or two I will merge this in

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.