Skip to content
GitLab

[R] Use snake_case in method parameter names

Merged William Cheng requested to merge r-naming into master

Use snake_case in method parameter names (e.g. pet.id => pet_id) to conform to lintr

  • use a petstore.yaml specified for R client generator for testing
  • add "data_file" as reserved keyword
  • add test to cover data_file
  • better code format in RClientCodegen
  • tested locally the all tests passed

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

cc @Ramanth (2019/07) @saigiridhar21 (2019/07)