Skip to content
GitLab

[kotlin-client] Fixing bug in Kotlin Client with BigDecimal default value

Merged Administrator requested to merge github/fork/sjoblomj/kotlin_bigdecimal_default into master

Created by: sjoblomj

Fixes #10866 (closed).

When a property is of type number and has a default value, the Kotlin Client will generate code like val bar: java.math.BigDecimal? = 0, which will not compile, since an Int cannot be assigned to BigDecimal. This PR fixes that bug.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jimschubert @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m