Created by: koscejev
Fixes #11910 (closed)
This propagates param.contentType field from individual API endpoint definitions to the actual ApiClient and uses it to create RequestBody for each individual part with correct Content-Type header as well as correct serialization of the individual part's body. If not specified, the default Content-Type is "application/octet-stream" for files and "application/json" for models - see https://swagger.io/docs/specification/describing-request-body/multipart-requests/. The actual serialization of individual part's body is now reusing code for serialization of the non-multipart body, so it now properly handles many cases.
^ This part was also verified on our own internal project using ok-http4 library only.
Potential questions/risks:
- I'm not 100% sure about how this works for part bodies that are neither files, nor models. But since it reuses code that is handling non-multipart body, so it is consistent with that at least.
- Some samples still contain old code, even though other samples were updated by the specified script? How does this work?
- Should this go to
master
instead? I will rebase as necessary.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(5.3.0),6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@jimschubert, @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yutaka0m