Created by: osharav
Explicitly adding node.js 8 type definitions before ClientResponse interface was removed due to deprecation.
PR checklist
-
Read the contribution guidelines. -
Ran the shell script under ./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
. -
Filed the PR against the correct branch: master
,3.4.x
,4.0.x
. Default:master
. -
Copied the technical committee to review the pull request if your PR is targeting a particular programming language.
Description of the PR
As requested in: #1138 (closed) trying to fix issue with typescript compiler for typescript-node test. This seems to be a result of a change in the https://github.com/DefinitelyTyped/DefinitelyTyped repo. They have deprecated the ClientResponse interface in node 10. To resolve (at least until the generator uses the new IncomingMessage interface), I've specifically used the type definitions for node 8 in the relevant package.mustache file. I've ran the sample, installed node_modules and then confirmed that I can run tsc and see the compiled JavaScript.
Regards, Omer.