Merged
requested to merge github/fork/NoTuxNoBux/csharp-netcore-fix-file-parameter-deserialization into master
Created by: NoTuxNoBux
Fixes #10588 (closed).
OpenAPI responses with binary content have a method generated that returns a FileParameter
with the csharp-netcore generator, but this type can't actually be deserialized properly when the call is made, resulting in an error. The type is simply a wrapper for a stream, so reading the stream and creating the FileParameter
is sufficient to fix the problem.
Testing done is that we've tried this fix proposed in #10588 (closed) successfully and are using it in production with an OpenAPI that has the following 200 response definition for a GET request that downloads a file:
{
"description": "The call was successful.",
"content": {
"image/png": {
"schema": { "type": "string", "format": "binary" }
}
}
}
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(5.3.0),6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @mandrean, @frankyjuang, @shibayan, @Blackclaws, @lucamazzanti