Created by: ctron
When an enum is used as part of the path, the compilation will fail as the enum implements ToString
but not Display
.
However, implementing Display
automatically implements ToString
. So this PR implements Display
in favor of ToString
.
Also see: https://doc.rust-lang.org/std/string/trait.ToString.html
This trait is automatically implemented for any type which implements the Display trait. As such, ToString shouldn’t be implemented directly: Display should be implemented instead, and you get the ToString implementation for free.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(5.3.0),6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@frol @farcaller @richardwhiuk @paladinzh