Created by: emajo
@mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02) @Blackclaws (2021/03) @lucamazzanti (2021/05)
Using the conditional serialization flag with the csharp-netcore generator each of the properties has a correspondent flag property that determines if it has or not to be serialized when the method toJson gets called. Using the setters of the properties it works as expected, the flags are set as they have to and the serialized json is alright, but if we set the class properties with the constructor, none of the flags gets set to true, so using the toJson method we get an empty json. This solution checks in the constructor if each property is null or not, if it isn’t, the according flag gets set to true.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(5.3.0),6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.