Created by: JulianGmp
Small fix that ensures the float literals (written for default values) in the generated C++ code are suffixed with an f
.
Before, this could cause a compile break because the literal would be interpreted as for example an integer before.
Note: this might be different for certain C++ compilers, I've encountered this with GCC 10.2.1.
It's a bit of a hack but hey it works.
Also: I ran the generate-samples script and did not encounter any changed files, so maybe this is an edge case not caught by the examples.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(5.3.0),6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. Cc @ravinikam (2017/07) @stkrwork (2017/07) @etherealjoy (2018/02) @MartinDelille (2018/03) @muttleyxd (2019/08)