Created by: spacether
python-experimental adds DecimalSchema (type: string format: number)
- DecimalSchema allows user to send number amounts as strings to preserve the desired sig figs.
- I also added isDecimal to CodegenModel; this was needed to get the feature working
- Decimal changed to decimal.Decimal in case someone creates a component named Decimal
- An import path in model tests was fixed for python-experimental
- The
__new__
methods for models now returnsModelName
so pycharm type hints will show instance properties on instances created withinst = ModelName({})
Note: for DecimalSchemas like these, one could also define string validations like a regex that requires a specific number of sig figs.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(5.3.0),6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.