Created by: ckoegel
Generated python sdks previously threw an AttributeError when attempting to deserialize a file in an HTTP response body if there was no filename=
attribute in the Content-Disposition header. model_utils.mustache
has been updated to include support for responses with no filename in this header. The deserialize_file
function now validates the type of the regex search before assigning the filename to the regex group. The regex search has been given a flag to allow it to search case-insensitively. If no filename is present, one is generated using the uuid
library.
This can be validated by hitting the endpoint in the FastAPI app below. Removing ; filename="test.png"
from the Content-Disposition header will cause the temporary file to be named default_<uuid>
. With the filename populated, the filename will be test.png
.
from fastapi import FastAPI, Response
app = FastAPI()
@app.get("/test-media")
async def media(response: Response):
response.headers['Content-Disposition'] = 'attachment; filename="test.png"'
response.headers['Content-Type'] = 'image/png'
response.status_code = 200
return response
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(5.3.0),6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@taxpon (2017/07) @frol (2017/07) @mbohlool (2017/07) @cbornet (2017/09) @kenjones-cisco (2017/11) @tomplus (2018/10) @Jyhess (2019/01) @arun-nalla (2019/11) @spacether (2019/11)