Created by: ityuhui
In the functions *_parseFromJSON
of the generated C-libcurl client code, when an error occurs, all the non-primitive variables will be freed before the function exits.
e.g.
pet_t *pet_parseFromJSON(cJSON *petJSON){
...
// pet->id
cJSON *id = cJSON_GetObjectItemCaseSensitive(petJSON, "id");
if (id) {
if(!cJSON_IsNumber(id))
{
goto end; //Numeric
}
}
// pet->category
cJSON *category = cJSON_GetObjectItemCaseSensitive(petJSON, "category");
category_t *category_local_nonprim = NULL;
...
end:
if (category_local_nonprim) {
category_free(category_local_nonprim);
category_local_nonprim = NULL;
}
return NULL;
}
But sometimes, the variables are not defined and initialized at this time. e.g. category_local_nonprim
is not defined if id
is invalid. Freeing category_local_nonprim
will cause core-dump.
The fix solution is to define and initialize non-primitive variables at the beginning of function.
e.g.
pet_t *pet_parseFromJSON(cJSON *petJSON){
// define the local varable for pet->category
category_t *category_local_nonprim = NULL;
// pet->id
cJSON *id = cJSON_GetObjectItemCaseSensitive(petJSON, "id");
if (id) {
if(!cJSON_IsNumber(id))
{
goto end; //Numeric
}
}
// pet->category
cJSON *category = cJSON_GetObjectItemCaseSensitive(petJSON, "category");
...
}
Hi @wing328 @zhemant @michelealbano
Could you please review this PR ? Thanks !
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.