Created by: chameleon82
This is follow up https://github.com/OpenAPITools/openapi-generator/pull/10166 PR to fix generation of Array[Byte]
type for the case:
properties:
byteStringpProperty:
type: string
format: byte
Ref https://swagger.io/docs/specification/data-models/data-types/
The root of cause is defined default as primitive type ByteArray with type mapping from ByteArray
to Array[Byte]
will be obfuscated to Array[Byte]
when toModelName
applied.
Proposed solution: do not apply toModelName
for explicit language mappings.
Other possible solutions:
- return
Array[Byte]
ongetTypeDeclaration
. Has disadvantage as string/byte openapi type is notArraySchema
and wrapper type need to be calculated within internal type. As on lower level that conversion already leads toByteArray
which can be solved with more flexible explicit typeMapping that solution looks not clean.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(5.3.0),6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@clasnake (2017/07), @jimschubert (2017/09)