Here is a list of improvement to fix most of the cppcheck and clazy warning by a generated code:
- Remove unsused variable
- Don't create temporary item when iterating
- Pass QString parameter by const reference
- Pass a context object as 3rd connect parameter (https://github.com/KDE/clazy/blob/master/docs/checks/README-connect-3arg-lambda.md)
The second commit improve the coding style.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master(5.3.0),6.0.x -
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@ravinikam @stkrwork @etherealjoy @muttleyxd