Created by: sheepdreamofandroids
All functions in the kotlin-client are marked suspend but the final call to OkHttp was blocking the thread. This is no longer the case.
Note that this can have impact on integration tests that verify backend calls because now it can happen that one call fails and therefore cancels the whole hierarchy of coroutines which possible cancels other backend calls before they even started. That IS desired behaviour though.
This code is a subset of a few patches that are running in production.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
(5.3.0),6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@jimschubert, @dr4ke616, @karismann, @Zomzog, @andrewemery, @4brunu, @yutaka0m