Skip to content
GitLab

Bug fix: Kotlin generator doesn't support inheritance

Merged Administrator requested to merge github/fork/irishshagua/issue_1025 into master

Created by: irishshagua

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
    • Can't find a 3.3.x branch, so just using default 🤷‍♂️
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language. @jimschubert @dr4ke616

Description of the PR

Kinda fix for Issue 1025

  • allVars is duplicating child preoperties when models are inherited. Filter out these duplicates in the KotlinSpringServerCodegen
  • isInherited property was not being populated in the CodegenModel, re-parse the models in the KotlinSpringServerCodegen class and populate the property here
  • Add template support for Kotlin models which require inheritance from a base class to support oneOf declarations in the api yaml