Skip to content
GitLab

Libcurl CMake adaptations

Merged Administrator requested to merge github/fork/ahmedyarub/ay/adapt_curl_cmake into master

Created by: ahmedyarub

@zhemant @ityuhui @michelealbano

Remove default build type and library shared flag Add OpenSSL using imported targets on supported CMake versions PreTarget and PostTarget scripts where the former one is used to add new source files and run additional find_package() commands, and the latter can be used to add optional components such as whether to include building examples and also to customize the installation command.

Related PR which I'm going to close in favor of this later: https://github.com/kubernetes-client/c/pull/75

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.