Skip to content
GitLab

[TypeScript] Make OpenAPI Generator serialize subclasses properly

Merged Administrator requested to merge github/fork/CenterEdge/master into master

Created by: gbrown-ce

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Motivation

Previously, when serializing as subclass of a property, generated swagger clients would only serialize properties of the parent class causing some values to not be pass through

Modifications

Before serializing attributes of a given type, we check to see if there is a specific type to be serialized so that we don't miss any properties.

Issue: https://github.com/OpenAPITools/openapi-generator/issues/100

@TiFu @taxpon @sebastianhaas @kenisteward @Vrolijkx @macjohnny @wing328