Created by: duxiaofeng-github
window
should not be used in typescript-fetch because window
does not exist under node js environment.
According to https://github.com/OpenAPITools/openapi-generator/pull/3326, fetch
is globally defined in both browser and nodejs.
So we just need to simply use fetch
.
Also I found out why the fetch
function need to bind window
again in the old code.
Because when the fetch
function passed by the fetchApi
getter, the fetch
function will lose its context(window) and cause an error 'Fetch TypeError: Failed to execute 'fetch' on 'Window': Illegal invocation'.
So, DO NOT pass the fetch
function by the fetchApi
getter, call fetch
directly wherever it needs to be executed.
PR checklist
-
Read the contribution guidelines. -
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community. -
Run the following to build the project and update samples: ./mvnw clean package ./bin/generate-samples.sh ./bin/utils/export_docs_generators.sh
./bin/generate-samples.sh bin/configs/java*
. For Windows users, please run the script in Git BASH. -
File the PR against the correct branch: master
,5.3.x
,6.0.x
-
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.