Merged
requested to merge 5841-increase-the-width-of-the-record-and-instr-column-views-in-drmemtrace into master
Created by: lihasgupta
In the trace view in drmemtrace the column widths are set to 9 characters. Very often this we encounter record#
and instr#
fields that have more characters than this. This makes interpreting the output difficult. An example view like this is:
<record#> <instr#>: T<tid> <record details>
------------------------------------------------------------
43564449812929999994: T442476 read 4 byte(s) @ 0x00002407b00887a8 by PC 0x0000560fd9e5b99e
43564449822929999995: T442476 ifetch 5 byte(s) @ 0x0000560fd9e5b9a3 be 00 4e 00 00 mov $0x00004e00 -> %esi
43564449832929999996: T442476 ifetch 2 byte(s) @ 0x0000560fd9e5b9a8 31 d2 xor %edx %edx -> %edx
In this example it is very difficult to tell when the record#
field ends and the instr#
field begins. This PR increases the width of these columns to help reduce the frequency of this issue.
With this PR the views will now look like this:
<--record#-> <--instr#->: <---tid---> <record details>
------------------------------------------------------------
1 0: T3256418 <marker: version 4>
2 0: T3256418 <marker: filetype 0x240>
3 0: T3256418 <marker: cache line size 64>
4 0: T3256418 <marker: chunk instruction count 1024>
5 0: T3256418 <marker: page size 4096>
6 0: T3256418 <marker: timestamp 13312410768080478>
7 0: T3256418 <marker: tid 3256418 on core 7>
8 1: T3256418 ifetch 3 byte(s) @ 0x00007fc205a61940 48 89 e7 mov %rsp, %rdi
9 2: T3256418 ifetch 5 byte(s) @ 0x00007fc205a61943 e8 b8 0c 00 00 call $0x00007fc205a62600
10 2: T3256418 write 8 byte(s) @ 0x00007fff9a9e3528 by PC 0x00007fc205a61943
11 3: T3256418 ifetch 1 byte(s) @ 0x00007fc205a62600 55 push %rbp
12 3: T3256418 write 8 byte(s) @ 0x00007fff9a9e3520 by PC 0x00007fc205a62600
13 4: T3256418 ifetch 3 byte(s) @ 0x00007fc205a62601 48 89 e5 mov %rsp, %rbp
14 5: T3256418 ifetch 2 byte(s) @ 0x00007fc205a62604 41 57 push %r15
15 5: T3256418 write 8 byte(s) @ 0x00007fff9a9e3518 by PC 0x00007fc205a62604
16 6: T3256418 ifetch 2 byte(s) @ 0x00007fc205a62606 41 56 push %r14
17 6: T3256418 write 8 byte(s) @ 0x00007fff9a9e3510 by PC 0x00007fc205a62606
18 7: T3256418 ifetch 2 byte(s) @ 0x00007fc205a62608 41 55 push %r13
19 7: T3256418 write 8 byte(s) @ 0x00007fff9a9e3508 by PC 0x00007fc205a62608
20 8: T3256418 ifetch 2 byte(s) @ 0x00007fc205a6260a 41 54 push %r12